[Chance]

I think you are missing one of the main benefits of witchcraft, the special potions that encourage them to actually be valuable and secretly trade with people in cities, versus necromancers that can offer... blatantly evil ore and not much else.

I agree that witches just have a playstyle miscommunication, or in other words, a skill issue.

Honest question though, how do you trade inside cities without getting caught though?

All it takes is for a single customer to call you out, and suddenly they'll have proof in the form of potions only witches can make.
Only way I can see such trades happening is if the witch does so while in disguise, and by then it is better not to do it inside the city since the disguise itself will be a most often than not be a tell too.

agreed, trading as a witch should be done in their disguise as a "black market" kind of deal, outside of the cities

unfortunately once a witch exposes their identity to anyone that may expose them they are extremely vulnerable and at risk